Disable edit icon because of DCO issues#39
Conversation
disable instead of remove to be able to keep the same template wit all our sites and only comment config meta value Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
EdJoJob
left a comment
EdJoJob
left a comment
There was a problem hiding this comment.
Any commit field enables DCO Sign-off. You need to add Signed-off-by: Name <email> in the commit message. We are protected against this reaching master by our DCO checks, and our protected master branch. So we will have PR that may need some work to get the DCO fixed, but it is safe.
If you still want the edit button removed that is fine, but I would like to make sure that "How DCO is enabled" is well understood
|
@EdJoJob The thing is that this button is primarily expected to be used by occasional contributors, people who just want to fix a typo, so we can't expect them to know how to add the sign-off manually and it will inevitably lead to issues and more support. So I prefer to disable it given it never really proved its usefulness. |
2 participants
PR description
Disable edit icon because of DCO issues (see ticket)
Disable only instead of remove to be able to keep the same template with all our
sites and only comment config meta value.
Fixed Issue(s)
fix PAN-3208